Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify in README whether this plugin actually works with Spring AOP #8

Open
erikthered opened this issue Apr 29, 2015 · 3 comments
Open

Comments

@erikthered
Copy link
Contributor

There is a section in the README comparing Spring AOP vs AspectJ, but it doesn't indicate whether it's possible to use this plugin in conjunction with Spring AOP. Can the README be updated to state clearly whether this works with Spring AOP?

@astefanutti
Copy link
Owner

Thanks for the suggestion.

A reference can be added at the beginning of that section to point to the metrics-spring project which is supposed to be used in Spring based applications to integration Metrics and Spring AOP. I wonder whether that section is really bringing value here though.

Let me know what you think.

@erikthered
Copy link
Contributor Author

Well, I feel like an idiot now. I didn't even see that there was a specific integration with Spring for DropWizard Metrics.

I think the Spring AOP vs AspectJ section might even be somewhat confusing in its current form. It might be worth making clear that this integration is for use only with AspectJ and that the metrics-spring project should be used with projects using Spring to do AOP.

@astefanutti
Copy link
Owner

No worries. Thanks for the feedback.

I'll rework that section to add pointers to metrics-spring, metrics-cdi, metrics-guice and make it clear in what context each one is to be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants