Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use standard library net/context library #161

Closed
BrianHicks opened this issue Aug 17, 2016 · 5 comments
Closed

use standard library net/context library #161

BrianHicks opened this issue Aug 17, 2016 · 5 comments
Assignees
Labels

Comments

@BrianHicks
Copy link
Contributor

BrianHicks commented Aug 17, 2016

we're using golang.org/x/net/context. With the 1.7 release, net/context is now in the standard library.

We will probably need to tweak the Go version we're using in CI as well.

@sehqlr
Copy link
Contributor

sehqlr commented Aug 17, 2016

In fetch/http.go, we import golang.org/x/net/context/ctxhttp, which is still available in 1.7. Should that stay as is, or will that need to change also?

@BrianHicks
Copy link
Contributor Author

It should be available without the x.

On Aug 17, 2016, at 11:53 AM, Sam Hatfield notifications@github.com wrote:

In fetch/http.go, we import golang.org/x/net/context/ctxhttp, which is still available in 1.7. Should that stay as is, or will that need to change also?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub, or mute the thread.

@sehqlr
Copy link
Contributor

sehqlr commented Aug 17, 2016

The context lib was moved to it's own top-level package, not under net, so ctxhttp isn't there, either

@sehqlr
Copy link
Contributor

sehqlr commented Aug 17, 2016

Alright, I have a PR open for this: #164. Also, wercker uses the golang:latest docker image, which is at 1.7

@sehqlr
Copy link
Contributor

sehqlr commented Aug 17, 2016

This was fixed, closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants