Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant calculations slowing down performance #15

Closed
MatthewScholefield opened this issue Apr 18, 2018 · 2 comments
Closed

Redundant calculations slowing down performance #15

MatthewScholefield opened this issue Apr 18, 2018 · 2 comments

Comments

@MatthewScholefield
Copy link
Contributor

After reverting this PR the performance suffers due to redundant calculations. For the time being, I plan on uploading a fork with the change to PyPI so that it can be included in other projects via setup.py.

@astorfi
Copy link
Owner

astorfi commented Apr 19, 2018

@MatthewScholefield The pull request broke some part of the package so I had to remove it temporarily. I am not quite sure about your point to upload another fork to PyPI. You mean related to SpeechPy?
This pull request is not compatible with the whole package structure. It needs further investigation.
Please feel free to have your own work but regarding the upload to PyPI or other kinds of independent upload please make sure to LICENSE file.

About being included in other projects via setup.py, I am not quite sure if I got the difference.
Please send me your feedback.

@MatthewScholefield
Copy link
Contributor Author

What do you mean exactly by not being compatible? Are you referring to an import error when run in Python 2? Let me know if this PR looks any better.

@astorfi astorfi closed this as completed Apr 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants