Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement flake8-self #2411

Closed
1 task
ngnpope opened this issue Jan 31, 2023 · 1 comment · Fixed by #2470
Closed
1 task

Implement flake8-self #2411

ngnpope opened this issue Jan 31, 2023 · 1 comment · Fixed by #2470
Labels
plugin Implementing a known but unsupported plugin

Comments

@ngnpope
Copy link
Contributor

ngnpope commented Jan 31, 2023

GitHub, PyPI.

  • SLF001: Private member access

Detects accessing a private attribute, e.g. obj._private, but allows for self._private, cls._private, and mcs._private (for in metaclasses). It doesn't currently check that cls._private is only within a class method, etc., which is something that could be improved. It also always allows access to dunders, e.g. obj.__eq__.
@spaceone
Copy link
Contributor

spaceone commented Jan 31, 2023 •
edited
Loading

I would like to differentiate the rule between _private and __private/_Class__private members. Maybe SLF001 and SLF002.

@charliermarsh charliermarsh added the plugin Implementing a known but unsupported plugin label Jan 31, 2023
@saadmk11 saadmk11 mentioned this issue Feb 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
plugin Implementing a known but unsupported plugin
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[flake8-self] Add Plugin and Rule SLF001 saadmk11/ruff
3 participants
@spaceone @charliermarsh @ngnpope