Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

regression from 269 to 270: noqa expected on wrong line for B024 #4646

Closed
atom-andrew opened this issue May 24, 2023 · 1 comment · Fixed by #4647
Closed

regression from 269 to 270: noqa expected on wrong line for B024 #4646

atom-andrew opened this issue May 24, 2023 · 1 comment · Fixed by #4647
Assignees

Comments

@atom-andrew
Copy link

from abc import ABC
from dataclasses import dataclass


@dataclass
class Foo(ABC):  # noqa: B024
    """ Foo """

ruff check passes on v0.0.269 and fails on v0.0.270 with:

file.py:5:1: B024 `Foo` is an abstract base class, but it has no abstract methods

If the noqa is moved up to the line with @DataClass, it passes.

@charliermarsh
Copy link
Member

Thank you, sorry about that. It'll be fixed in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants