Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP 701 linter changes #7299

Closed
9 tasks done
Tracked by #6502
dhruvmanila opened this issue Sep 12, 2023 · 0 comments
Closed
9 tasks done
Tracked by #6502

PEP 701 linter changes #7299

dhruvmanila opened this issue Sep 12, 2023 · 0 comments
Assignees
Labels
linter Related to the linter python312 Related to Python 3.12

Comments

@dhruvmanila
Copy link
Member

dhruvmanila commented Sep 12, 2023

PEP 701 in the lexer and parser is complete, and it's time to move on to make the necessary changes in the linter. This will mainly involve token-based rules or anything which uses the lexer in some way. The work items section contains a list of issues which needs to be fixed.

The lexer and parser changes cannot be merged without making the necessary changes across the linter. This is the reason that any pull requests which is made to fix any of the following issues needs to be based on the latest parser changes which as of this writing is #7263 (branch dhruv/fstring-parser-3). The risk here for any external contributor are:

  • The contributor will have to base their branch on the latest parser branch (dhruv/fstring-parser-3)
  • If there are any changes made to the base branch, which is unlikely as of now, the downstream branches needs to be rebased as well

With the above points in mind, an external contributor may choose to work on any of the mentioned issues. If so, please comment on the respective issue to be assigned. Feel free to reach out for any kind of queries either here on GitHub or on Discord.

Workflow

What would working on these issues look like?

  1. git checkout main
  2. git pull - Make sure to be on the latest changes
  3. git checkout -b fix-issue-xxxx dhruv/fstring-parser-3 - Create a local branch based on the latest f-string parser branch
  4. Work on the respective issue, commit the changes and open a pull request.

Work items

@dhruvmanila dhruvmanila added rule Implementing or modifying a lint rule python312 Related to Python 3.12 linter Related to the linter and removed rule Implementing or modifying a lint rule labels Sep 12, 2023
@dhruvmanila dhruvmanila self-assigned this Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter Related to the linter python312 Related to Python 3.12
Projects
None yet
Development

No branches or pull requests

1 participant