Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split string module #9987

Merged
merged 2 commits into from Feb 14, 2024
Merged

split string module #9987

merged 2 commits into from Feb 14, 2024

Conversation

MichaReiser
Copy link
Member

Summary

I started to find it difficult to navigate the string/mod.rs and decided to split it into any containing the AnyString* types
and normalize containing the normalization logic.

This has the benefit that mod.rs now mainly contains the code related to formating continuations, quotes, and prefixes.

Test Plan

cargo test

@MichaReiser MichaReiser added the internal An internal refactor or improvement label Feb 14, 2024
Copy link

ruff-ecosystem results

Formatter (stable)

✅ ecosystem check detected no format changes.

Formatter (preview)

✅ ecosystem check detected no format changes.

Copy link
Member

@dhruvmanila dhruvmanila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍

@MichaReiser MichaReiser merged commit fe79798 into main Feb 14, 2024
17 checks passed
@MichaReiser MichaReiser deleted the split-string-module branch February 14, 2024 17:54
nkxxll pushed a commit to nkxxll/ruff that referenced this pull request Mar 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants