Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue where tools that failed to install still appear #225

Merged
merged 1 commit into from May 27, 2023

Conversation

ischaojie
Copy link
Contributor

I can still see it with rye tools list after a failed install with rye install hakuna. It looks like this is caused by not cleaning up after the failure.

Before:

➜  o git:(main) ✗ rye tools install hakuna
ERROR: Could not find a version that satisfies the requirement hakuna (from versions: none)
ERROR: No matching distribution found for hakuna
Error: tool installation failed
➜  o git:(main) ✗ rye tools list
hakuna
...

After:

➜  o git:(main) ✗ rye tools install hakuna
ERROR: Could not find a version that satisfies the requirement hakuna (from versions: none)
ERROR: No matching distribution found for hakuna
Error: tool installation failed
➜  o git:(main) ✗ rye tools list
...

@mitsuhiko mitsuhiko merged commit 07d2672 into astral-sh:main May 27, 2023
6 checks passed
@ischaojie ischaojie deleted the fix branch October 12, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants