fix rye config --show-path #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Now that we have a basic test infrastructure, could you add a test for this? |
|
Yeah will do.
|
PR astral-sh#660 (ff130c4) makes an action argument required. This breaks `rye config --show-path`. This fixes this behavior by requiring any argument, but showing help when no argument is provided. fix
Some tests, such as testing rye config, do not require a project, hence init can be unused.
Add a filter for [RYE_HOME]. This will be used for outputs such as `rye config --show-path`
We add configuration tests as an integration insta test, as we want to go through the whole process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where
rye config --show-pathwill not work. Thisregression was originally introduced in #660.
This PR now makes
--show-pathconflicting with any other flag, and groups action and format flags into an ArgGroup. We added integration tests to continuously ensure the behavior is correct.