Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verbose/quiet for rye lint and format #959

Merged
merged 2 commits into from Mar 29, 2024

Conversation

bluss
Copy link
Contributor

@bluss bluss commented Mar 28, 2024

These commands produced ruff --verbose check (same for --quiet and same for format) but the verbose/quiet need to come after the subcommand. The command would produce an error (file check/format does not exist), now it succeeds.

Fixes #956

These commands produced ruff --verbose check  (same for --quiet and same
for format) but the verbose/quiet need to come after the subcommand.
@bluss
Copy link
Contributor Author

bluss commented Mar 28, 2024

I noticed that the help for --quiet in Rye is "turn off all output" but that's not what ruff says it does. ruff has --silent for that. Could be a change or addition in the future, to support it.

@mitsuhiko mitsuhiko merged commit 4fbd9bd into astral-sh:main Mar 29, 2024
@bluss bluss deleted the fix-lint-format branch March 29, 2024 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rye fmt is not reformatting file
2 participants