use tracing for telemetry #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit replaces log and flexilogger by tracing and tracing-subscriber. The default log level is `info`, which can be overriden by using the `RUST_LOG` environment variable with directives as described in the tracing subscriber docs: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/filter/struct.EnvFilter.html Because env var directives are strictly more powerful than setting verbosity levels on the command line the `log-level` flag is removed. If astria-conductor is connected to a tty it will emit tracing events using human-readable format. If it is not connected to a tty it will emit JSON. By default logging is disabled in integration tests. It can be enabled by setting the environment variable `TEST_LOG=1`. Note that the service no longer writes explicitly writes logs to a file. Because astria-conductor is intended to be run as a service by a service manager or orchestration platform, it is assumed that persisting logs is handled externally.
SuperFluffy
force-pushed
the
superfluffy/tracing
branch
from
34e04fd
to
436c4fd
Compare
steezeburger
approved these changes
May 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit replaces log and flexilogger by tracing and tracing-subscriber. The default log level is
info, which can be overriden by using theRUST_LOGenvironment variable with directives as described in the tracing subscriber docs: https://docs.rs/tracing-subscriber/0.3.17/tracing_subscriber/filter/struct.EnvFilter.htmlBecause env var directives are strictly more powerful than setting verbosity levels on the command line the
log-levelflag is removed.If astria-conductor is connected to a tty it will emit tracing events using human-readable format. If it is not connected to a tty it will emit JSON.
By default logging is disabled in integration tests. It can be enabled by setting the environment variable
TEST_LOG=1.Note that the service no longer writes explicitly writes logs to a file. Because astria-conductor is intended to be run as a service by a service manager or orchestration platform, it is assumed that persisting logs is handled externally.
Partially addresses #14