Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

newly proposed blocks should be marked "head", and commited should be marked "safe" #50

Closed
noot opened this issue Jun 7, 2023 · 2 comments
Labels
conductor pertaining to the astria-conductor crate proto pertaining to the Astria Protobuf spec

Comments

@noot
Copy link
Collaborator

noot commented Jun 7, 2023

When tendermint proposes a new block, the block contains the commit for the parent block. However, the conductor currently treats this incorrectly, as when it receives a newly-proposed block, it executes it and marks it as safe/softly-committed, even though it's not actually finalized by tendermint yet. The correct logic when receiving a newly proposed block would be:

  • execute and mark newly proposed block as "head" of chain
  • verify commit contained in block (which is for the parent block), if it's verified, then mark parent block as "safe"
  • receiving block from DA remains the same

Requires:

  • updating the gRPC service to have methods such as:
ExecuteAndMarkAsHead(txs, prev_block_hash)
SetBlockAsSafe(block_hash)
SetBlockAsFinal(block_hash)
  • updating the geth fork to support these methods
  • updating conductor to correctly handle newly proposed vs committed blocks

blocked by #44

@noot noot added conductor pertaining to the astria-conductor crate proto pertaining to the Astria Protobuf spec labels Jun 7, 2023
@emhane
Copy link
Contributor

emhane commented Sep 18, 2023

all blocks will be finalised, this issue is obsolete now right? there is no need to validate commitment to the rollup data because ProcessProposal does that so if we trust the validators and we trust the connection to the full node then all blocks that are final are valid.

@noot archive?

@noot
Copy link
Collaborator Author

noot commented Sep 19, 2023

yeah i think this is probably a duplicate of #207 at this point, will close

there is no need to validate commitment to the rollup data

we still need to do this when reading from DA

@noot noot closed this as completed Sep 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conductor pertaining to the astria-conductor crate proto pertaining to the Astria Protobuf spec
Projects
None yet
Development

No branches or pull requests

2 participants