Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docker container flows #58

Merged
merged 1 commit into from Jun 9, 2023
Merged

Add docker container flows #58

merged 1 commit into from Jun 9, 2023

Conversation

joroshiba
Copy link
Member

@joroshiba joroshiba commented Jun 7, 2023

Builds and pushes images for astria-conductor and astria-sequencer-relayer.

Images will be pushed to the astriaorg/conductor and astriaorg/sequencer-relayer package repositories respectively.

Fixes #42

@joroshiba joroshiba temporarily deployed to BUF June 7, 2023 23:00 — with GitHub Actions Inactive
@joroshiba joroshiba temporarily deployed to BUF June 7, 2023 23:02 — with GitHub Actions Inactive
@joroshiba joroshiba temporarily deployed to BUF June 7, 2023 23:17 — with GitHub Actions Inactive
@joroshiba joroshiba temporarily deployed to BUF June 7, 2023 23:57 — with GitHub Actions Inactive
@joroshiba joroshiba temporarily deployed to BUF June 8, 2023 00:34 — with GitHub Actions Inactive
@joroshiba joroshiba temporarily deployed to BUF June 8, 2023 00:48 — with GitHub Actions Inactive
@joroshiba joroshiba temporarily deployed to BUF June 8, 2023 01:00 — with GitHub Actions Inactive
@joroshiba joroshiba temporarily deployed to BUF June 8, 2023 01:26 — with GitHub Actions Inactive
Copy link
Member

@SuperFluffy SuperFluffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the filtering strategy will cause issues.

Also the filtering for arm64 is no longer necessary.

I lean bothways when it comes to the tags (i.e. release a global tag for all images to ensure they play together vs. tagging the services/binaries individiually). I can see the lock-step as being an advantage.

.github/workflows/docker-build.yml Show resolved Hide resolved
.github/workflows/docker-build.yml Outdated Show resolved Hide resolved
.github/workflows/docker-build.yml Outdated Show resolved Hide resolved
@joroshiba
Copy link
Member Author

joroshiba commented Jun 8, 2023

I lean bothways when it comes to the tags (i.e. release a global tag for all images to ensure they play together vs. tagging the services/binaries individiually). I can see the lock-step as being an advantage.

@SuperFluffy My argument here would be that using a single tag to release all packages breaks semantic versioning.

Practically, sequencer-relayer and conductor are highly linked, but we need a tagging strategy that works across anything in monorepo. I don't want to release a new minor version of the sequencer and thus a new minor version of our EVM rollup even if there are no breaking changes to the EVM.

The tagging format I've gone with fits within semver regex, and I believe (could be wrong) will auto work with the tagging functionality that exists in the docker actions. I'm working on figuring out how to test this.

@joroshiba joroshiba temporarily deployed to BUF June 8, 2023 17:48 — with GitHub Actions Inactive
@joroshiba joroshiba temporarily deployed to BUF June 8, 2023 18:22 — with GitHub Actions Inactive
@joroshiba joroshiba added the ci issues that are related to ci and github workflows label Jun 8, 2023
@joroshiba joroshiba marked this pull request as ready for review June 8, 2023 18:46
@joroshiba joroshiba temporarily deployed to BUF June 8, 2023 20:56 — with GitHub Actions Inactive
Copy link
Member

@SuperFluffy SuperFluffy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me now.

@joroshiba joroshiba temporarily deployed to BUF June 9, 2023 16:05 — with GitHub Actions Inactive
Adds a reusable workflow for building and pushing docker images, as well as a workflow which utilizes that to deploy both sequencer-relayer and conductor.
@joroshiba joroshiba merged commit bb3cbe7 into main Jun 9, 2023
8 checks passed
@joroshiba joroshiba deleted the joroshiba/docker-workflows branch June 9, 2023 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci issues that are related to ci and github workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generate OCI images on github actions in monorepo
3 participants