New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docker container flows #58
Conversation
857343d
to
b537d6a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the filtering strategy will cause issues.
Also the filtering for arm64 is no longer necessary.
I lean bothways when it comes to the tags (i.e. release a global tag for all images to ensure they play together vs. tagging the services/binaries individiually). I can see the lock-step as being an advantage.
@SuperFluffy My argument here would be that using a single tag to release all packages breaks semantic versioning. Practically, The tagging format I've gone with fits within semver regex, and I believe (could be wrong) will auto work with the tagging functionality that exists in the docker actions. I'm working on figuring out how to test this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me now.
f66910c
to
6849e72
Compare
6849e72
to
3fa18b6
Compare
Adds a reusable workflow for building and pushing docker images, as well as a workflow which utilizes that to deploy both sequencer-relayer and conductor.
f2c3936
to
8e0a2f1
Compare
Builds and pushes images for
astria-conductor
andastria-sequencer-relayer
.Images will be pushed to the
astriaorg/conductor
andastriaorg/sequencer-relayer
package repositories respectively.Fixes #42