Pin icon fix #15
Closed
Pin icon fix #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 21, 2020 09:54
|
@luisaugusto thank you very much for the fix. Will merge ASAP. |
|
@astrit thanks, I tried it in both Firefox 72.0.2 and 73.0b8. I'm running on MacOS 10.15.2. |
|
This PR is no longer possible to be merged since there is a local generator for all icons and needs to be there first but the issue mentioned is fixed. Unfortunately I have to close it, I apologize for the inconvinience. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While using the various icons, I noticed that the pin icon has an issue rendering on Firefox when it is scaled:
This is due to the
box-shadowproperty being set toinsetwhile also using thetransformproperty to scale the item. It works well in all other browsers except Firefox. To resolve the issue, I replaced thebox-shadowwith aborder: 2px solidand adjusted the circle to be placed correctly in the pin with the new offset being at the border. The icon looks exactly the same as it had been before, but now renders correctly across all browsers.