Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom solution type #13

Closed
Tracked by #68
fjebaker opened this issue Apr 22, 2022 · 1 comment
Closed
Tracked by #68

Custom solution type #13

fjebaker opened this issue Apr 22, 2022 · 1 comment
Labels
analysis Issue or pull request related to an analysis technique or method enhancement New feature or request integrator Issue or pull request related to integration methods

Comments

@fjebaker
Copy link
Member

To facilitate a nicer analysis API, I suggest we move to wrap the SciMLBase types in our own struct, so that we can dispatch methods more targetedly. This would allow us to add plotting recipes unique to our package, allow overloads with the statistics community's fit functions, and generally let us be more expressive.

We could then also track which coordinates a given solution is in (Cartesian vs spherical), and provide mappings between them.

@fjebaker fjebaker added enhancement New feature or request integrator Issue or pull request related to integration methods analysis Issue or pull request related to an analysis technique or method labels Apr 22, 2022
@fjebaker
Copy link
Member Author

Closing, since we now basically do that with unpack_solution*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
analysis Issue or pull request related to an analysis technique or method enhancement New feature or request integrator Issue or pull request related to integration methods
Projects
Status: Done
Development

No branches or pull requests

1 participant