Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation #76

Closed
fjebaker opened this issue Feb 10, 2023 · 2 comments
Closed

Update documentation #76

fjebaker opened this issue Feb 10, 2023 · 2 comments
Labels
documentation Improvements or additions to documentation

Comments

@fjebaker
Copy link
Member

Self descriptive

@fjebaker fjebaker added the documentation Improvements or additions to documentation label Feb 10, 2023
@phajy
Copy link
Contributor

phajy commented Jun 15, 2023

The Covariant radiative transfer example isn't working. The documentation is likely lagging behind the code but I couldn't figure it out myself at a quick look - will continue looking.

The code in the documentation produces the following

ERROR: TypeError: in keyword argument μ, expected Float64, got a value of type Int64

@fjebaker
Copy link
Member Author

@phajy yes I am aware of this bug, it was broken in

The code that fixes it is in master, via

but the version has not been bumped since, which is why the registry version is still out of date.

I will open an issue about adding the examples to a seperate test-suite though, so that these breaking changes are caught earlier. They were removed to reduce the test runner time, but this isn't the first time an example has broken since that was done, so they should really be added back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants