upgrade to NANv2 #123
upgrade to NANv2 #123
Conversation
|
Yes! this will fix #121 |
|
@julianduque thanks! |
|
@c4milo @sonnyp it should use g++-4.8 on travis, check this for reference: justinlatimer/node-midi@6b2fff5 |
|
@julianduque @sonnyp I already upgraded .travis.yml to use g++ 4.8, it's failing right now because this PR hasn't been merged. |
|
Added the travis update in this PR, thanks @c4milo |
julianduque
force-pushed
the
master
branch
2 times, most recently
from
5154357
to
b062938
Compare
|
💃 |
| @@ -1,12 +1,25 @@ | |||
| sudo: false | |||
| sudo: required | |||
There was a problem hiding this comment.
to install g++-4.8, it's required due newer versions of V8
There was a problem hiding this comment.
sudo is not needed for installation of packages via travis apt addon
There was a problem hiding this comment.
thought it was required, I rollback the value back to false then
|
@c4milo @julianduque out of curiosity; why should it use GCC 4.8? |
|
@sonnyp the short version is that newer versions of node requires it and travis comes with an older version of gcc. |
julianduque
force-pushed
the
master
branch
2 times, most recently
from
6d57b6a
to
ec89233
Compare
|
thanks a lot; released/published as |
|
\o/, thanks for reviewing @sonnyp! |
Add support for io.js 3.0.0 and the upcoming Node.js 4.0.0