Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated deps, including nan #154

Merged
merged 1 commit into from Jun 30, 2016
Merged

Updated deps, including nan #154

merged 1 commit into from Jun 30, 2016

Conversation

fiznool
Copy link
Contributor

@fiznool fiznool commented Jun 2, 2016

Fixes issues when running on node v6.

For example, compiling with older nan can result in the following warning:

(node) v8::ObjectTemplate::Set() with non-primitive values is deprecated
(node) and will stop working in the next major release.

@matzew
Copy link

matzew commented Jun 14, 2016

Any change to merge this and release a new version ?

@fiznool fiznool mentioned this pull request Jun 20, 2016
Closed
@wtfaremyinitials
Copy link

👍

@astro astro merged commit cfa2e55 into xmppo:master Jun 30, 2016
@astro
Copy link
Collaborator

astro commented Jun 30, 2016

Thank you very much!

@matzew
Copy link

matzew commented Jun 30, 2016

@astro any change to get a release version published?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fiznool @matzew @wtfaremyinitials @astro