Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make stringprep usage optional #8

Merged
1 commit merged into from
Nov 30, 2010
Merged

make stringprep usage optional #8

1 commit merged into from
Nov 30, 2010

Conversation

trentm
Copy link
Contributor

@trentm trentm commented Nov 30, 2010

"npm install" fails on the node-stringprep dependency on Mac OS X. I played with trying to get node-stringprep to build, but couldn't, either with the icu installs with "brew" or with MacPorts.

From what I understand stringprep is only being used for case-normalization (and possibly other types of normalization?) of international domain names. As a result I've tried to make the usage of stringprep optional here.

Would you be interested in merging this patch? I'd be happy to adjust it if it doesn't work for you as is.

Cheers,
Trent

StringPrep is used for ICU-based string normalization for international
domain names. Unfortunately it is very difficult to get building on Mac.
Too large a penalty for internal domain names.. for me at least right now.
@astro
Copy link
Member

astro commented Nov 30, 2010

Thanks!

v0.2.3 is out with some minor modifications to this feature.

@donquixote
Copy link

Hi,
node-stringprep is now optional, but..

  • still a warning showing up with each command, that can be confusing. esp, if you have other errors in your custom app, and think they must be caused by the stringprep thing (which they are not)
  • documentation (README) should explain installation of stringprep and icu. E.g. i had no idea what "icu" is and that i can install it with apt-get in debian.

One solution to point 1:
var xmpp = require('node-xmpp').noStringPrep()

-> that would be a conscious decision by the developer that he currently cannot install stringprep, or does not want it. so the message can be removed.

Thanks!

sonnyp added a commit that referenced this pull request Jun 7, 2016
use JavaScript Standard Style
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants