Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup.py requires numpy #13

Closed
albireox opened this issue Nov 18, 2017 · 2 comments
Closed

setup.py requires numpy #13

albireox opened this issue Nov 18, 2017 · 2 comments

Comments

@albireox
Copy link

The current version of setup.py imports numpy to get its include path. I'm finding this to be a problem when you add fast-histogram as a dependency in your requirements.txt. Even if you also add numpy as a requirement, there is no way to enforce that numpy will have been installed by the time the setup.py in fast-histogram gets run.

@astrofrog
Copy link
Owner

This is a general problem not specific to fast-histogram (see e.g. https://stackoverflow.com/questions/27021270/how-to-handle-dependency-on-scipy-in-setup-py or https://stackoverflow.com/questions/21605927/why-doesnt-setup-requires-work-properly-for-numpy). But I do have some ideas on adjusting the setup.py to prevent this kind of issue, so I'll look into it.

@astrofrog
Copy link
Owner

I fixed this in #15

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants