Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

reduced chi2 calculation #33

Closed
johnarban opened this issue Oct 15, 2015 · 1 comment
Closed

reduced chi2 calculation #33

johnarban opened this issue Oct 15, 2015 · 1 comment

Comments

@johnarban
Copy link

for determining the chi_2 per datapoint (options 'E' and 'F'), FitInfo.keep() uses source.n_wav to determine the number of data points, instead of n_data. Since the fitting is only constrained by n_data points, should not the chi_2 be calculated using souce.n_data instead of souce.n_wav?
@astrofrog
Copy link
Owner

@johnarban - indeed this was incorrect, I have fixed it in #49 - sorry for the long delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@astrofrog @johnarban