Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch up astro deployment update #181

Closed
schnie opened this issue Feb 25, 2019 · 6 comments · Fixed by #195
Closed

Touch up astro deployment update #181

schnie opened this issue Feb 25, 2019 · 6 comments · Fixed by #195
Assignees

Comments

@schnie
Copy link
Member

schnie commented Feb 25, 2019

astro deployment update should list possible flags:

virajparekh@orbiter:~$ astro de update
Error: must specify a deployment ID and at least one attribute to update.
Usage:
  astro deployment update [flags]

Aliases:
  update, up

Examples:

	astro deployment update UUID label=Production-Airflow

Flags:
  -h, --help   help for update

Global Flags:
      --workspace-id string   workspace assigned to deployment

I'm not entirely sure what we can even do with this command right now. If it does work, we may just need to document it better.

@andriisoldatenko
Copy link
Contributor

@andriisoldatenko
Copy link
Contributor

andriisoldatenko commented Mar 6, 2019

Most magic code here is args, which we send to payload, need to dig into huston code.
and than may be here ->
https://github.com/astronomer/houston-api/blob/master/src/resolvers/mutation/update-deployment/index.js#L49-L50

@andriisoldatenko
Copy link
Contributor

@schnie please take a look ^

@schnie
Copy link
Member Author

schnie commented Mar 6, 2019

@andriisoldatenko How would someone use the command now? Does it work?

Is it a matter of passing args like: astro deployment update --name new-name --version some-version?

@schnie
Copy link
Member Author

schnie commented Mar 13, 2019

@andriisoldatenko how do you specify the payload to the mutation using the CLI now? Does it work currently?

@andriisoldatenko
Copy link
Contributor

@schnie @vparekh94 you can try, but I also not sure what we can pass as key/value

astro deployment update UUID key=value key1=value2

For instance:

$ astro deployment update cjt7gwnl20m4j0b08vmc1fm92 k=andrii1233333333
 NAME       DEPLOYMENT NAME                  ASTRO     DEPLOYMENT ID
 andrii     spherical-constellation-8941     0.7.5     cjt7gwnl20m4j0b08vmc1fm92

 Successfully updated deployment
$ astro deployment list
 NAME       DEPLOYMENT NAME                  ASTRO      DEPLOYMENT ID
 andrii     spherical-constellation-8941     v0.7.5     cjt7gwnl20m4j0b08vmc1fm92

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants