Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dead link in comment within airflow_settings.yaml #244

Closed
paolaperaza opened this issue Jul 2, 2019 · 0 comments · Fixed by #245
Closed

Dead link in comment within airflow_settings.yaml #244

paolaperaza opened this issue Jul 2, 2019 · 0 comments · Fixed by #245
Assignees

Comments

@paolaperaza
Copy link
Contributor

The airflow_settings.yaml file automatically generated when you astro airflow init via the CLI by default links out to a docs page that no longer exists/doesn't live at that URL.

Current link: https://github.com/astronomer/docs/blob/master/docs/cli-airflow-configuration.md

Link should be: https://github.com/astronomer/docs/blob/master/v0.9/cli-airflow-configuration.md

$ ls
Dockerfile		airflow_settings.yaml	dags			include			packages.txt		plugins			requirements.txt
Paolas-MacBook-Pro:astro-trial paola$ more airflow_settings.yaml
# This feature is in Beta.
# Please report any bugs to https://github.com/astronomer/astro-cli/issues
# NOTE: If putting a dict for any field, please wrap in single quotes.
# More details you can find https://github.com/astronomer/docs/blob/master/docs/cli-airflow-configuration.md 
airflow:
  connections:
    - conn_id:
      conn_type:
      conn_host:
      conn_login:
      conn_password:
      conn_port:
      conn_extra:
  pools:
    - pool_name:
      pool_slot:
      pool_description:
  variables:
    - variable_name:
      variable_value:
airflow_settings.yaml (END)

Would we still consider this feature in beta, @schnie @andriisoldatenko? Not a huge deal here, but figured I'd create an issue to draw attention to the docs link and in case we wanted to otherwise adjust that comment at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants