Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename config.json to astro.json to avoid old CLI conflicts #42

Closed
andscoop opened this issue Mar 5, 2018 · 1 comment · Fixed by #44
Closed

Rename config.json to astro.json to avoid old CLI conflicts #42

andscoop opened this issue Mar 5, 2018 · 1 comment · Fixed by #44
Assignees
@andscoop
Milestone
3/14/18

Comments

@andscoop
Copy link
Contributor

andscoop commented Mar 5, 2018

Proposal to rename ./astro/config.json to ./astro/astro.json in order to avoid conflicts between configurations in the old CLI and the new CLI. This could make dev and internal work easier while we continue to support two CLIs.
@schnie
Copy link
Member

schnie commented Mar 5, 2018

Documenting that we talked offline and decided to change viper to use yaml instead of json. YAML is easier to work with and makes this problem go away.

@andscoop andscoop mentioned this issue Mar 6, 2018
Merged
@andscoop andscoop added this to the 3/14/18 milestone Mar 6, 2018
@andscoop andscoop self-assigned this Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@andscoop andscoop

Labels
None yet
Projects
None yet
Milestone
3/14/18
Development

Successfully merging a pull request may close this issue.

Feature/36 42 config improvements astronomer/astro-cli
3 participants
@ryw @schnie @andscoop