Fix commands in README.md
#242
Conversation
Codecov Report
@@ Coverage Diff @@
## main #242 +/- ##
=======================================
Coverage 89.88% 89.88%
=======================================
Files 67 67
Lines 3538 3538
Branches 341 341
=======================================
Hits 3180 3180
Misses 316 316
Partials 42 42 Continue to review full report at Codecov.
|
kaxil
force-pushed
the
fixes-readme-commands
branch
2 times, most recently
from
b617d76
to
10b1a8a
Compare
| @@ -94,12 +94,25 @@ airflow db init | |||
| Create an SQLite database for the example to run with and run the DAG: | |||
| ``` | |||
| sqlite3 /tmp/sqlite_default.db "VACUUM;" | |||
| airflow dags test calculate_top_animations `date --iso-8601=seconds` | |||
| airflow dags test calculate_popular_movies `date -Iseconds` | |||
There was a problem hiding this comment.
It might be worth updating on line 43 to also have the same name
There was a problem hiding this comment.
L43 is the name of the dag file though, and this is the dag_id
There was a problem hiding this comment.
I know - but it can simplify to the end-user keeping them with the same value in this case.
README.md
Outdated
| ```commandline | ||
| sqlite3 /tmp/sqlite_default.db "select * from top_animation;" ".exit" | ||
| ```shell | ||
| # The sqlite_default host is different for MAC vs. Linux |
There was a problem hiding this comment.
🙈 I didn't realise that was the case
There was a problem hiding this comment.
I didn’t know too 😄 - It is because of the following line:
Which returns a different dir /var/random_nums on my mac🤦♂️
README.md
Outdated
| @@ -94,12 +94,25 @@ airflow db init | |||
| Create an SQLite database for the example to run with and run the DAG: | |||
| ``` | |||
| sqlite3 /tmp/sqlite_default.db "VACUUM;" | |||
There was a problem hiding this comment.
Why do we need this line? isn't it redundant?
There was a problem hiding this comment.
Updated to use env var to get file name.
This PR fixes 3 issues:
(1) It changes the `date` command to make it run on MacOS. Otherwise MacOS users will see the following error:
```
❯ date --iso-8601=seconds
date: illegal option -- -
usage: date [-jnRu] [-r seconds|file] [-v[+|-]val[ymwdHMS]]
[-I[date | hours | minutes | seconds]]
[-f fmt date | [[[mm]dd]HH]MM[[cc]yy][.ss]] [+format]
```
(2) The `dag_id` was wrong in `airflow dags test` command
(3) Fix URL for Airflow homepage
(4) The sqlite_default host is different for MAC vs. Linux so I have fixed that.
kaxil
force-pushed
the
fixes-readme-commands
branch
from
10b1a8a
to
908131d
Compare
This PR fixes 3 issues:
(1) It changes the `date` command to make it run on MacOS. Otherwise MacOS users will see the following error:
```
❯ date --iso-8601=seconds
date: illegal option -- -
usage: date [-jnRu] [-r seconds|file] [-v[+|-]val[ymwdHMS]]
[-I[date | hours | minutes | seconds]]
[-f fmt date | [[[mm]dd]HH]MM[[cc]yy][.ss]] [+format]
```
(2) The `dag_id` was wrong in `airflow dags test` command
(3) Fix URL for Airflow homepage
(4) The sqlite_default host is different for MAC vs. Linux so I have fixed that.
This PR fixes 4 issues in our
README.md:(1) It changes the
datecommand to make it run on MacOS. Otherwise MacOS users will see the following error:(2) The
dag_idwas wrong inairflow dags testcommand(3) Fix URL for Airflow homepage
(4) The sqlite_default host is different for MAC vs. Linux so I have fixed that.