Support params
argument in aql.render
to declare values to SQL Jinja template #125
#254
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
At the moment, Astro 0.5.1 does not use the
params
keyword argument. This argument would allow us to overwrite SQL Jinja template values.Example:
Currently raises the error:
Acceptance criteria
aql.render
can override Jinja template values by using theparams
argumentexample_dag
which usesparams
This PR addresses one part of the previous PR that was not correctly implemented, namely the adding params at a task level as well as at the DAG level
addresses #125