Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issues with using BigQuery Connection created from UI #294

Merged
merged 2 commits into from
Apr 9, 2022

Conversation

kaxil
Copy link
Collaborator

@kaxil kaxil commented Apr 6, 2022

This PR creates a constant for CONN_TYPE_TO_DATABASE and adds gcpbigquery to it. It then uses this for other places .

closes #252

@kaxil kaxil requested a review from utkarsharma2 April 6, 2022 20:59
@codecov
Copy link

codecov bot commented Apr 6, 2022

Codecov Report

Merging #294 (7cbaa91) into main (1ab6f7a) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #294   +/-   ##
=======================================
  Coverage   92.28%   92.28%           
=======================================
  Files          35       35           
  Lines        1530     1530           
  Branches      273      273           
=======================================
  Hits         1412     1412           
  Misses         86       86           
  Partials       32       32           
Impacted Files Coverage Δ
src/astro/sql/operators/agnostic_stats_check.py 94.73% <ø> (ø)
src/astro/utils/__init__.py 82.35% <ø> (ø)
src/astro/constants.py 100.00% <100.00%> (ø)
src/astro/utils/database.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ab6f7a...7cbaa91. Read the comment docs.

@kaxil
Copy link
Collaborator Author

kaxil commented Apr 8, 2022

Would love reviews on this @utkarsharma2 @tatiana

This PR creates a constant for `CONN_TYPE_TO_DATABASE` and adds `gcpbigquery` to it. It then uses this for other places .

closes #252
@utkarsharma2 utkarsharma2 merged commit 75e10a4 into main Apr 9, 2022
@utkarsharma2 utkarsharma2 deleted the bigquery-fix branch April 9, 2022 04:49
kaxil added a commit that referenced this pull request Jul 1, 2022
I updated it in #294 but missed the google extra.
kaxil added a commit that referenced this pull request Jul 1, 2022
I updated it in #294 but missed the google extra.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reading or writing from Bigquery doesn't work with Airflow's bigquery connection type
2 participants