Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve code quality base on DeepSource #299

Merged
merged 1 commit into from Apr 7, 2022
Merged

Conversation

tatiana
Copy link
Collaborator

@tatiana tatiana commented Apr 7, 2022

During the development of PR #296, DeepSource identified:

  • Method '_table_exists_in_db' is abstract in class 'SqlDecoratedOperator' but is not overridden
  • Method 'handle_dataframe_func' is abstract in class 'SqlDecoratedOperator' but is not overridden

In several subclasses, as part of:

DeepSource identified:
Method '_table_exists_in_db' is abstract in class 'SqlDecoratedOperator' but is not overridden
Method 'handle_dataframe_func' is abstract in class 'SqlDecoratedOperator' but is not overridden

In several subclasses, as part of:
https://deepsource.io/gh/astro-projects/astro/run/99bc601f-513a-4dbc-b771-65cf795aa2aa/python/PYL-W0223
@codecov
Copy link

codecov bot commented Apr 7, 2022

Codecov Report

Merging #299 (c473be6) into main (f9a50f4) will increase coverage by 0.22%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #299      +/-   ##
==========================================
+ Coverage   92.05%   92.27%   +0.22%     
==========================================
  Files          35       35              
  Lines        1535     1527       -8     
  Branches      268      268              
==========================================
- Hits         1413     1409       -4     
+ Misses         90       86       -4     
  Partials       32       32              
Impacted Files Coverage Δ
src/astro/sql/operators/sql_decorator.py 92.14% <ø> (+0.86%) ⬆️
src/astro/sql/parsers/sql_directory_parser.py 94.39% <ø> (+1.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9a50f4...c473be6. Read the comment docs.

@tatiana tatiana marked this pull request as ready for review April 7, 2022 14:18
@kaxil kaxil merged commit ba19088 into main Apr 7, 2022
@kaxil kaxil deleted the deepsource-sqldecorator branch April 7, 2022 23:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants