Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plan a strategy to gracefully handle dataframes so users don't trash Airflow metadata database #444

Closed
1 task
tatiana opened this issue Jun 8, 2022 · 1 comment · Fixed by #522
Closed
1 task
Assignees
Labels
priority/critical Critical priority
Milestone

Comments

@tatiana
Copy link
Collaborator

tatiana commented Jun 8, 2022

Context

At the moment the dataframe decorator adds the entire content of a dataframe to Airflow XCom. Depending on how the user set XCom, this can potentially trash Airflow's metadata database (if the user is using the default XCom backend).

There are a few approaches we could use to deal with this:

  • Give warnings to users if they use the dataframe decorator with the default backend
  • Not allow users to use the dataframe decorator with the default backend if the dataframe is larger than a specific size
  • Others

The goal with this ticket is propose a solution for the problem.

Acceptance criteria

  • Log a ticket with the agreed approach
@tatiana tatiana added the priority/critical Critical priority label Jun 16, 2022
@kaxil kaxil added this to the 1.0.0 milestone Jun 23, 2022
@dimberman dimberman self-assigned this Jul 7, 2022
@dimberman
Copy link
Collaborator

@tatiana I think one solution here would be to force users to explicitly set an environment variable of "yes I know that I'm putting dataframes in the airlfow metadata and yes I know that's dangerous". Something like "ASTRO__DATAFRAME__ALLOW_UNSAFE_STORAGE" cc: @kaxil

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/critical Critical priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants