New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kl/upgrade/rename xhw to x size #35
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugobuddel
reviewed
Jul 8, 2020
OK good, I'll change it in MicadoWISE too |
Because I'm getting rid of the notebooks and converting them to .rst files.
The code will be included via the jupyter-sphinx module
…-------------------------------------
Kieran Leschinski
Department of Astrophysics
University of Vienna
Am Mi., 8. Juli 2020 um 12:49 Uhr schrieb Hugo Buddelmeijer <
notifications@github.com>:
***@***.**** commented on this pull request.
------------------------------
In .travis.yml
<#35 (comment)>:
> @@ -31,4 +31,4 @@ jobs:
script:
- pytest
- # - pytest --doctest-modules
+# - jupyter nbconvert --execute docs/source/_static/scopesim_basic_intro.ipynb
Why remove the notebook test? That's one way to get travis to pass
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#35 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACH66QS2FBE2EB3B72VECCTR2RFM3ANCNFSM4OUK3W7Q>
.
|
Issue: https://gitlab.astro-wise.org/micado/micadowise/-/issues/80 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hugobuddel - not sure if it makes sense for you to review this, as there is a lot of crap along side the actual purpose of the branch. Feel free to just push it though. I've double checked my code changes and travis is green.
Detector lists
Added backwards compatibility so that detecotr lists will accept column names "xhw" and "x_size"
xhw - x half-width [mm], a legacy of simcado
x_size - the full width of the detector in the x direction [mm]
The same applies for yhw and y_size
Also added provision to accept pixsize and pixel_size
Surface lists
Added a test that shows that we can avoid filename and just pass transmission and wavelength arrays directly via an array_dict construct
5-liner docs
Some format changes to the 5-liner documentation, plus some additions