Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kl/upgrade/rename xhw to x size #35

Merged
merged 23 commits into from Jul 8, 2020
Merged

Conversation

astronomyk
Copy link
Collaborator

@hugobuddel - not sure if it makes sense for you to review this, as there is a lot of crap along side the actual purpose of the branch. Feel free to just push it though. I've double checked my code changes and travis is green.

Detector lists

Added backwards compatibility so that detecotr lists will accept column names "xhw" and "x_size"
xhw - x half-width [mm], a legacy of simcado
x_size - the full width of the detector in the x direction [mm]

The same applies for yhw and y_size

Also added provision to accept pixsize and pixel_size

Surface lists

Added a test that shows that we can avoid filename and just pass transmission and wavelength arrays directly via an array_dict construct

5-liner docs

Some format changes to the 5-liner documentation, plus some additions

@astronomyk astronomyk requested review from hugobuddel and removed request for hugobuddel July 8, 2020 08:46
@astronomyk astronomyk merged commit 46ee865 into master Jul 8, 2020
@astronomyk astronomyk deleted the kl/upgrade/rename_xhw_to_x_size branch July 8, 2020 10:31
.travis.yml Show resolved Hide resolved
@hugobuddel
Copy link
Collaborator

OK good, I'll change it in MicadoWISE too

@astronomyk
Copy link
Collaborator Author

astronomyk commented Jul 8, 2020 via email

@hugobuddel
Copy link
Collaborator

OK good, I'll change it in MicadoWISE too

Issue: https://gitlab.astro-wise.org/micado/micadowise/-/issues/80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants