Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for nested dict not acting like a dict #373

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Conversation

teutoburg
Copy link
Contributor

This is a bit of a hack, but after extensive discussion, it was decided to apply it anyway until an overall better solution is found.

This is a bit of a hack, but after extensive discussion, it was decided to
apply it anyway until an overall better solution is found.
@teutoburg teutoburg self-assigned this Feb 23, 2024
@teutoburg teutoburg added the no release notes Do not include this PR in the release notes label Feb 23, 2024
Copy link

codecov bot commented Feb 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.29%. Comparing base (d32dd06) to head (5f7ac86).

Additional details and impacted files
@@             Coverage Diff             @@
##           dev_master     #373   +/-   ##
===========================================
  Coverage       74.28%   74.29%           
===========================================
  Files              56       56           
  Lines            7815     7818    +3     
===========================================
+ Hits             5805     5808    +3     
  Misses           2010     2010           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teutoburg teutoburg changed the title Fix nested dict not acting like a dict Workaround for nested dict not acting like a dict Feb 23, 2024
Copy link
Collaborator

@hugobuddel hugobuddel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@hugobuddel
Copy link
Collaborator

I'll merge this so the nightly run will verify that everything now works

@hugobuddel hugobuddel merged commit d786495 into dev_master Feb 23, 2024
25 checks passed
@hugobuddel hugobuddel deleted the fh/fix-dic branch February 23, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no release notes Do not include this PR in the release notes
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants