Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsatisfied assert #386

Merged
merged 1 commit into from
Mar 5, 2024
Merged

Remove unsatisfied assert #386

merged 1 commit into from
Mar 5, 2024

Conversation

hugobuddel
Copy link
Collaborator

Fixes broken HAWKI/test_hawki/test_full_package_hawki.py , see https://github.com/AstarVienna/ScopeSim_Data/actions/runs/8151320997/job/22279022262#step:5:2374

Copy link

codecov bot commented Mar 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.92%. Comparing base (5db9f65) to head (a5ad214).

Additional details and impacted files
@@              Coverage Diff               @@
##           dev_master     #386      +/-   ##
==============================================
- Coverage       74.93%   74.92%   -0.01%     
==============================================
  Files              56       56              
  Lines            7779     7777       -2     
==============================================
- Hits             5829     5827       -2     
  Misses           1950     1950              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks, I wanted to do that but then totally forgot 😅

@teutoburg
Copy link
Contributor

I'll merge this, so the next nightly run won't fail on it...

@teutoburg teutoburg merged commit bc51dce into dev_master Mar 5, 2024
25 checks passed
@teutoburg teutoburg deleted the hugobuddel-patch-1 branch March 5, 2024 22:32
@hugobuddel
Copy link
Collaborator Author

The ScopeSim_Data run now succeeds, https://github.com/AstarVienna/ScopeSim_Data/actions/runs/8167219925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants