-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Also show scopsim version in bug_report #394
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev_master #394 +/- ##
==============================================
- Coverage 74.92% 74.90% -0.03%
==============================================
Files 56 56
Lines 7777 7778 +1
==============================================
- Hits 5827 5826 -1
- Misses 1950 1952 +2 ☔ View full report in Codecov by Sentry. |
Is it intentional that this PR merges into |
Oh oops, that was not intentional, thanks for spotting that |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Certainly a useful addition, not sure why we didn't already do that. Haven't tested how the out of this will look now, but I'm sure you did that 🙂👍
What's with all those "8 commits from last year"? Maybe rebase this onto dev_master before merging? |
Oops, yeah indeed, I'll do that |
4bb1101
to
d7cf42b
Compare
I took the liberty to do so and will merge as soon as it passes 🙂 |
No description provided.