Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also show scopsim version in bug_report #394

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Conversation

hugobuddel
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 74.90%. Comparing base (6057f73) to head (d7cf42b).

Additional details and impacted files
@@              Coverage Diff               @@
##           dev_master     #394      +/-   ##
==============================================
- Coverage       74.92%   74.90%   -0.03%     
==============================================
  Files              56       56              
  Lines            7777     7778       +1     
==============================================
- Hits             5827     5826       -1     
- Misses           1950     1952       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@teutoburg
Copy link
Contributor

Is it intentional that this PR merges into master and not dev_master? That might also be the reason the CI fails due to outdated workflow files...

@hugobuddel hugobuddel changed the base branch from master to dev_master April 5, 2024 13:19
@hugobuddel
Copy link
Collaborator Author

Oh oops, that was not intentional, thanks for spotting that

Copy link
Contributor

@teutoburg teutoburg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Certainly a useful addition, not sure why we didn't already do that. Haven't tested how the out of this will look now, but I'm sure you did that 🙂👍

@teutoburg
Copy link
Contributor

What's with all those "8 commits from last year"? Maybe rebase this onto dev_master before merging?

@teutoburg teutoburg added the enhancement New feature or request label Apr 5, 2024
@hugobuddel hugobuddel marked this pull request as draft April 5, 2024 13:42
@hugobuddel
Copy link
Collaborator Author

What's with all those "8 commits from last year"? Maybe rebase this onto dev_master before merging?

Oops, yeah indeed, I'll do that

@teutoburg
Copy link
Contributor

What's with all those "8 commits from last year"? Maybe rebase this onto dev_master before merging?

Oops, yeah indeed, I'll do that

I took the liberty to do so and will merge as soon as it passes 🙂

@teutoburg teutoburg marked this pull request as ready for review April 11, 2024 09:02
@teutoburg teutoburg merged commit da4d77f into dev_master Apr 11, 2024
25 checks passed
@teutoburg teutoburg deleted the hugobuddel-patch-1 branch April 11, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants