Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPAC benchmark failing #17

Closed
astrofrog opened this issue Jun 18, 2016 · 0 comments
Closed

IPAC benchmark failing #17

astrofrog opened this issue Jun 18, 2016 · 0 comments

Comments

@astrofrog
Copy link
Member

The following benchmarks are currently failing:

 62.50%] ··· Running io_ascii.time_ipac.IPACSuite.time_data_str_vals                                                                                                              failed
[ 62.50%] ····· Traceback (most recent call last):
                  File "/Users/tom/miniconda3/envs/dev35/lib/python3.5/site-packages/asv-0.2.dev966+211cc811-py3.5.egg/asv/benchmark.py", line 792, in <module>
                    commands[mode](args)
                  File "/Users/tom/miniconda3/envs/dev35/lib/python3.5/site-packages/asv-0.2.dev966+211cc811-py3.5.egg/asv/benchmark.py", line 769, in main_run
                    result = benchmark.do_run()
                  File "/Users/tom/miniconda3/envs/dev35/lib/python3.5/site-packages/asv-0.2.dev966+211cc811-py3.5.egg/asv/benchmark.py", line 453, in do_run
                    return self.run(*self._current_params)
                  File "/Users/tom/miniconda3/envs/dev35/lib/python3.5/site-packages/asv-0.2.dev966+211cc811-py3.5.egg/asv/benchmark.py", line 528, in run
                    timing = timer.timeit(number)
                  File "/Users/tom/tmp/astropy-benchmarks/env/705fbb2b350520526769cb8754181ec0/lib/python3.4/timeit.py", line 186, in timeit
                    timing = self.inner(it, self.timer)
                  File "/Users/tom/tmp/astropy-benchmarks/env/705fbb2b350520526769cb8754181ec0/lib/python3.4/timeit.py", line 87, in inner
                    _func()
                  File "/Users/tom/tmp/astropy-benchmarks/benchmarks/io_ascii/time_ipac.py", line 38, in time_data_str_vals
                    data.str_vals()
                  File "/Users/tom/tmp/astropy-benchmarks/env/705fbb2b350520526769cb8754181ec0/lib/python3.4/site-packages/astropy/io/ascii/core.py", line 801, in str_vals
                    self._set_fill_values(self.cols)
                  File "/Users/tom/tmp/astropy-benchmarks/env/705fbb2b350520526769cb8754181ec0/lib/python3.4/site-packages/astropy/io/ascii/core.py", line 755, in _set_fill_values
                    colnames = set(self.header.colnames)
                AttributeError: 'IpacData' object has no attribute 'header'

[ 75.00%] ··· Running io_ascii.time_ipac.IPACSuite.time_get_cols                                                                                                                   failed
[ 75.00%] ····· Traceback (most recent call last):
                  File "/Users/tom/miniconda3/envs/dev35/lib/python3.5/site-packages/asv-0.2.dev966+211cc811-py3.5.egg/asv/benchmark.py", line 792, in <module>
                    commands[mode](args)
                  File "/Users/tom/miniconda3/envs/dev35/lib/python3.5/site-packages/asv-0.2.dev966+211cc811-py3.5.egg/asv/benchmark.py", line 769, in main_run
                    result = benchmark.do_run()
                  File "/Users/tom/miniconda3/envs/dev35/lib/python3.5/site-packages/asv-0.2.dev966+211cc811-py3.5.egg/asv/benchmark.py", line 453, in do_run
                    return self.run(*self._current_params)
                  File "/Users/tom/miniconda3/envs/dev35/lib/python3.5/site-packages/asv-0.2.dev966+211cc811-py3.5.egg/asv/benchmark.py", line 528, in run
                    timing = timer.timeit(number)
                  File "/Users/tom/tmp/astropy-benchmarks/env/705fbb2b350520526769cb8754181ec0/lib/python3.4/timeit.py", line 186, in timeit
                    timing = self.inner(it, self.timer)
                  File "/Users/tom/tmp/astropy-benchmarks/env/705fbb2b350520526769cb8754181ec0/lib/python3.4/timeit.py", line 87, in inner
                    _func()
                  File "/Users/tom/tmp/astropy-benchmarks/benchmarks/io_ascii/time_ipac.py", line 27, in time_get_cols
                    self.header.get_cols(self.lines)
                  File "/Users/tom/tmp/astropy-benchmarks/env/705fbb2b350520526769cb8754181ec0/lib/python3.4/site-packages/astropy/io/ascii/ipac.py", line 212, in get_cols
                    if self.ipac_definition == 'right':
                AttributeError: 'IpacHeader' object has no attribute 'ipac_definition'

[ 87.50%] ··· Running io_ascii.time_ipac.IPACSuite.time_header_str_vals                                                                                                            failed
[ 87.50%] ····· Traceback (most recent call last):
                  File "/Users/tom/miniconda3/envs/dev35/lib/python3.5/site-packages/asv-0.2.dev966+211cc811-py3.5.egg/asv/benchmark.py", line 792, in <module>
                    commands[mode](args)
                  File "/Users/tom/miniconda3/envs/dev35/lib/python3.5/site-packages/asv-0.2.dev966+211cc811-py3.5.egg/asv/benchmark.py", line 769, in main_run
                    result = benchmark.do_run()
                  File "/Users/tom/miniconda3/envs/dev35/lib/python3.5/site-packages/asv-0.2.dev966+211cc811-py3.5.egg/asv/benchmark.py", line 453, in do_run
                    return self.run(*self._current_params)
                  File "/Users/tom/miniconda3/envs/dev35/lib/python3.5/site-packages/asv-0.2.dev966+211cc811-py3.5.egg/asv/benchmark.py", line 528, in run
                    timing = timer.timeit(number)
                  File "/Users/tom/tmp/astropy-benchmarks/env/705fbb2b350520526769cb8754181ec0/lib/python3.4/timeit.py", line 186, in timeit
                    timing = self.inner(it, self.timer)
                  File "/Users/tom/tmp/astropy-benchmarks/env/705fbb2b350520526769cb8754181ec0/lib/python3.4/timeit.py", line 87, in inner
                    _func()
                  File "/Users/tom/tmp/astropy-benchmarks/benchmarks/io_ascii/time_ipac.py", line 33, in time_header_str_vals
                    header.str_vals()
                  File "/Users/tom/tmp/astropy-benchmarks/env/705fbb2b350520526769cb8754181ec0/lib/python3.4/site-packages/astropy/io/ascii/ipac.py", line 278, in str_vals
                    null = col.fill_values[core.masked]
                AttributeError: 'Column' object has no attribute 'fill_values'

[100.00%] ··· Running io_ascii.time_ipac.IPACSuite.time_splitter   

@taldcroft @hamogu - is this a real regression, or should the benchmarks be updated? (if the latter, could you open a PR to update them?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant