Rework Simbad to use TAP

[bsipocz]

Using TAP queries is more efficient for Simbad, and thus the internals of the module

[ManonMarchand]

• Sort current issues/PR about Simbad before starting the refactoring
• Increase coverage until satisfactory to be sure we wont break anything
• Following getting and sorting 'rot' values from simbad/measurements #243 discussion, add a TAP access directly. This will require extensive documentation with the navigation in the relational database
• Go back to every simbad issue where the answer was "go see pyvo" to see if we could do better

• simbad.query_object returns only first row in votable field "fe_h" #1781
• Simbad query not returning hierarchical membership information #2753
• Querying Simbad for rotational velocity #2679
• Return number of SIMBAD objects in paper associated with bibcode #1490
• How to generate a random set of data from SIMBAD without pulling a huge amount of objects? #1100
• Simbad Query for Magnitudes - case issue flux(j) versus flux(J) - mismatched field name throughout query #566
• getting and sorting 'rot' values from simbad/measurements #243
• Query Criteria Simbad catalog #2845

[ManonMarchand]

@keflavich : would you like to discuss these changes with @aoberto and me? We work at CDS and it's something that we will try to handle. Maybe you have an idea/some tips on how to do it properly?

[keflavich]

@ManonMarchand Sure, happy to discuss them. If you're going through with a refactoring to use TAP on the backend, I'd just request that you open a draft PR early so we can discuss user interface decisions as they are made. What else needs to be discussed? If you want to schedule a call, I can do that too.

[ManonMarchand]

The draft PR seems perfect 🙂
I guess we could have a call if there is something too hard to decide on by messages. Thanks!

[bsipocz]

Also, let me know if you're planning to travel to the next IVOA, we could certainly do some focused work there, if you think it would be helpful.