New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for #1647: jplhorizons upstream change #1650
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1650 +/- ##
=======================================
Coverage 62.97% 62.97%
=======================================
Files 185 185
Lines 14985 14985
=======================================
Hits 9437 9437
Misses 5548 5548
Continue to review full report at Codecov.
|
Thanks @mommermi! I'm ambivalent with the changelog, it doesn't need it as you stated the changes are internal, but users might be confused why the old version is not working any more when seamlessly nothing has happened to the module. So I would add one entry like we did for 0.4, and the merge this. |
I need to fix the (unrelated) issues with the deployment. Hopefully a release will hit pypi after that, over the weekend or early next week. |
Hi mommermi, Hope you're well. I find this post because i also have the bug "KeyError: 'ObsSub-LON'" whn using ephemerides() function. I saw you solved this bud and I've updaded my astroquery to 0.4 version but the bug stills exist ... Thanks for your help. |
@Olivier-Lakoue - Please upgrade your astroquery with |
Hi bsipocz, Thanks for your help, i've upgrade as mentionned and it's ok. This package is very greats, many thanks !! |
fixes error caused by upstream changes as documented in #1647
no changes to API, no changelog entry should be necessary