Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for #1647: jplhorizons upstream change #1650

Merged
merged 3 commits into from Feb 14, 2020
Merged

Conversation

mommermi
Copy link
Contributor

@mommermi mommermi commented Feb 14, 2020

fixes error caused by upstream changes as documented in #1647

no changes to API, no changelog entry should be necessary

@codecov
Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #1650 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1650   +/-   ##
=======================================
  Coverage   62.97%   62.97%           
=======================================
  Files         185      185           
  Lines       14985    14985           
=======================================
  Hits         9437     9437           
  Misses       5548     5548
Impacted Files Coverage Δ
astroquery/jplhorizons/__init__.py 100% <ø> (ø) ⬆️
astroquery/jplhorizons/core.py 66.77% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 332a908...3834598. Read the comment docs.

@bsipocz
Copy link
Member

bsipocz commented Feb 14, 2020

Thanks @mommermi! I'm ambivalent with the changelog, it doesn't need it as you stated the changes are internal, but users might be confused why the old version is not working any more when seamlessly nothing has happened to the module. So I would add one entry like we did for 0.4, and the merge this.

@bsipocz bsipocz merged commit c21da1c into astropy:master Feb 14, 2020
@bsipocz
Copy link
Member

bsipocz commented Feb 14, 2020

I need to fix the (unrelated) issues with the deployment. Hopefully a release will hit pypi after that, over the weekend or early next week.

@Olivier-Lakoue
Copy link

Hi mommermi,

Hope you're well.
I leave in France and i'm a new user of Astroquery and it's seems to be a very great api.

I find this post because i also have the bug "KeyError: 'ObsSub-LON'" whn using ephemerides() function.

I saw you solved this bud and I've updaded my astroquery to 0.4 version but the bug stills exist ...
I think i made a mistake with the upgrade, how can i do to make it works correctly ?

Thanks for your help.
Olivier.

@bsipocz
Copy link
Member

bsipocz commented Mar 23, 2020

@Olivier-Lakoue - Please upgrade your astroquery with pip install --pre -U astroquery

@Olivier-Lakoue
Copy link

Hi bsipocz,

Thanks for your help, i've upgrade as mentionned and it's ok.

This package is very greats, many thanks !!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Additional decimal places in sub-obs lat & long in JPL Horizons breaks astroquery.jplhorizons parser
3 participants