You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The keyword arguments should be changed to **kwargs when they have a None default (or... maybe we should just be adding a * in front of all those keyword args? @bsipocz chime in here to clarify what you meant in
I would certainly prefer to remove all usage of **kwargs and to be explicit of the accepted keywords. Their order should not matter though, so we should make them kwarg only by adding the * in the signature.
Note: it's package-novice for someone who wants to learn a bit more about astroquery's internal, the cleanup should be straightforward with plenty of examples in the other modules using our @async_to_sync decorator.
The Atomic package needs some refactoring as noted in #2088:
query_object
method should be removed in favor of using an_async
method with the default wrapper**kwargs
when they have aNone
default (or... maybe we should just be adding a*
in front of all those keyword args? @bsipocz chime in here to clarify what you meant in Atomic: change http->https, and do a lot of refactoring #2088 (comment))The text was updated successfully, but these errors were encountered: