Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atomic: Refactor #2090

Open
2 tasks
keflavich opened this issue Jun 21, 2021 · 2 comments
Open
2 tasks

Atomic: Refactor #2090

keflavich opened this issue Jun 21, 2021 · 2 comments

Comments

@keflavich
Copy link
Contributor

The Atomic package needs some refactoring as noted in #2088:

@bsipocz
Copy link
Member

bsipocz commented Jun 21, 2021

The keyword arguments should be changed to **kwargs when they have a None default (or... maybe we should just be adding a * in front of all those keyword args? @bsipocz chime in here to clarify what you meant in

I would certainly prefer to remove all usage of **kwargs and to be explicit of the accepted keywords. Their order should not matter though, so we should make them kwarg only by adding the * in the signature.

@bsipocz
Copy link
Member

bsipocz commented Jun 21, 2021

Note: it's package-novice for someone who wants to learn a bit more about astroquery's internal, the cleanup should be straightforward with plenty of examples in the other modules using our @async_to_sync decorator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants