Remove astroquery/utils/testing_tools.py
#2287
Conversation
|
(my approval is contingent on tests passing) |
|
|
||
| # Import MockResponse to keep the API while it's temporarily factored out to | ||
| # a separate file to avoid requiring pytest as a dependency in non-test code | ||
| from .mocks import MockResponse |
There was a problem hiding this comment.
I'm OK with the removal of this file, if you also clean up the mock import in the code.
There was a problem hiding this comment.
I ran the tests locally with
python setup.py testand nothing failed. Running the tests with tox does lead to the same failures as were seen in CI.
There was a problem hiding this comment.
I think some temporary files may have been left behind when you tested locally, but not when it was a fully independent build for tox. I expect that the testing would have failed after a git clean.
There was a problem hiding this comment.
I expect that the testing would have failed after a
git clean.
Indeed they do.
|
Also a short changelog along the lines of "removal of obsolete testing tools" would be useful, added to the last changelog section. |
The `MockResponse` class utilised in many tests is defined in `astroquery.utils.mocks`, but many modules imported it via `astroquery.utils.testing_tools`.
The deleted file defined two pytest fixtures. Neither was used anywhere, and their functionality is provided by `pytest-remotedata`.
eerovaher
force-pushed
the
rm-testing-tools
branch
from
2d46b87
to
0bd6724
Compare
Codecov Report
@@ Coverage Diff @@
## main #2287 +/- ##
==========================================
+ Coverage 62.72% 62.75% +0.02%
==========================================
Files 131 130 -1
Lines 16854 16835 -19
==========================================
- Hits 10572 10564 -8
+ Misses 6282 6271 -11
Continue to review full report at Codecov.
|
|
Thanks @eerovaher! |
The deleted file defined two pytest fixtures. Neither was used anywhere, and their functionality is provided by
pytest-remotedata.Closes #1134