Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NIST Vectorizing #2678

Merged
merged 3 commits into from Mar 31, 2023
Merged

NIST Vectorizing #2678

merged 3 commits into from Mar 31, 2023

Conversation

nkphysics
Copy link
Member

@nkphysics nkphysics commented Mar 3, 2023

Is this what yall had in mind for #682 ?
I'm not too sure since I can't access the fb post.
Tried to explore what Vizier was doing.
Figured I'd try to start off small (why I chose NIST).
These changes allow for querying multiple linenames with one request i.e...

 >>> from astroquery.nist import Nist
 >>> import astropy.units as u
 >>> table = Nist.query(4000 * u.AA, 7000 * u.AA, linename=["H I", "Fe I", "V I"])

There might be more that could be done for NIST but linename was the main place I thought this could be applied.
Maybe could also be applied to energy_level_unit, idk though that might make the responses messy.

@codecov
Copy link

codecov bot commented Mar 3, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@770949e). Click here to learn what that means.
The diff coverage is 100.00%.

❗ Current head 6b96846 differs from pull request most recent head 0475354. Consider uploading reports for the commit 0475354 to get more accurate results

@@           Coverage Diff           @@
##             main    #2678   +/-   ##
=======================================
  Coverage        ?   65.74%           
=======================================
  Files           ?      233           
  Lines           ?    17842           
  Branches        ?        0           
=======================================
  Hits            ?    11731           
  Misses          ?     6111           
  Partials        ?        0           
Impacted Files Coverage Δ
astroquery/nist/core.py 90.81% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nkphysics nkphysics marked this pull request as ready for review March 7, 2023 03:32
Copy link
Member

@ceb8 ceb8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

astroquery/nist/tests/test_nist.py Outdated Show resolved Hide resolved
astroquery/nist/core.py Outdated Show resolved Hide resolved
astroquery/nist/core.py Outdated Show resolved Hide resolved
@bsipocz bsipocz added the nist label Mar 16, 2023
@bsipocz bsipocz added this to the v0.4.7 milestone Mar 16, 2023
astroquery/nist/core.py Outdated Show resolved Hide resolved
@nkphysics
Copy link
Member Author

Looking at other PRs figured this might need a changelog entry, so I've gone ahead and added one just in case.

astroquery/nist/core.py Outdated Show resolved Hide resolved
astroquery/nist/tests/test_nist.py Outdated Show resolved Hide resolved
Copy link
Member

@bsipocz bsipocz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good, thank you!

I've also reworded the docs around the multiple lines.

@bsipocz bsipocz merged commit d0e8773 into astropy:main Mar 31, 2023
7 checks passed
@bsipocz
Copy link
Member

bsipocz commented Mar 31, 2023

Thanks @nkphysics!

@nkphysics nkphysics deleted the vectorize-nist branch March 31, 2023 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants