Fix ESO

[keflavich]

ESO queries are broken (see #969). We need to fix the module.

This is a WIP that fixes login. The todo items are:

• list_instruments
• list_surveys
• query_apex_quicklooks
• query_instrument
• query_survey
• query_surveys
• retrieve_data

[pep8speaks]

Hello @keflavich! Thanks for updating the PR.

Cheers ! There are no PEP8 issues in this Pull Request. 🍻

Comment last updated on September 08, 2017 at 17:35 Hours UTC

[astropy-bot]

Hi there @keflavich 👋 - thanks for the pull request! I'm just a friendly 🤖 that checks for issues related to the changelog and making sure that this pull request is milestoned and labelled correctly. This is mainly intended for the maintainers, so if you are not a maintainer you can ignore this, and a maintainer will let you know if any action is required on your part 😃.

Everything looks good from my point of view! 👍

[keflavich]

the conda-forge build appears to be failing. Beyond that, I think this is ready. @bsipocz, any thoughts abouts about the erroring build?

[bsipocz]

@keflavich - Travis has had issues with the osx builds for a few days now, I guess the failing build was part of that issue. I've restarted it now.

[keflavich]

@bsipocz I restarted it again, but it looked like maybe you had canceled? I'm ready to merge this PR unless you see any problems. The coverage decrease is fine and, afaict, the appveyor failure is some installation junk that is officially above my pay grade. I think I actually fixed the astropy-bot comments....

[bsipocz]

Travis totally shut down their osx infra, so I vote for merging this without that build (and yes, I've cancelled it again, so it's not blocking other astropy builds in the queue).

The bot complains about the missing changelog, but here it's not an issue at all do to at release time.

[bsipocz]

Hmm, the astropy-helpers change is definitely unneeded, would you remove that last commit?

[keflavich]

yeah, that seemed weird to me. Done.

[bsipocz]

Thanks! We can then just merge away, as everything except the osx has passed previously. Or are you waiting for the appveyor build?

[keflavich]

I'm OK to merge, but I also am not feeling all that impatient. I can wait for the builds to finish.

[bsipocz]

I'm pretty sure the appveyor issue can be traced back to this:
pyca/pyopenssl#674

I'll try to open a PR with a workaround, but first want to get the aastropy release out of the door.