Add an origin keyword to aperture plot methods #395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| origin : array-like, optional | ||
| The ``(x, y)`` position of the origin of the displayed | ||
| image. | ||
|
|
There was a problem hiding this comment.
Would you like to add e.g. where``(x,y)``corresponds to the usual rectangular coordinate system? (if that's the case).
There was a problem hiding this comment.
What other coordinate system did you have in mind? I think it's pretty clear that (x, y) means pixel coordinates if that's what you mean.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The origin keyword is useful for plotting apertures on a cutout or subsample of the data.
This PR also refactors the aperture
plotmethods by placing repeated code in a new_prepare_plotmethod on thePixelAperturebase class.