Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Broken link to old mailing list needs to be fixed #1075

Closed
pllim opened this issue Aug 23, 2023 · 4 comments · Fixed by sunpy/ndcube#632
Closed

DOC: Broken link to old mailing list needs to be fixed #1075

pllim opened this issue Aug 23, 2023 · 4 comments · Fixed by sunpy/ndcube#632

Comments

@pllim
Copy link
Member

pllim commented Aug 23, 2023

Example log: https://github.com/astropy/specutils/actions/runs/5922597630/job/16056813261

https://mail.scipy.org/pipermail/numpy-discussion/2010-July/051760.html is broken now. Remove it or replace it.

@rosteen
Copy link
Contributor

rosteen commented Aug 28, 2023

I'm trying to figure out where this link is even coming from, it's driving me crazy. Grepping the specutils project directory doesn't find anything 😵

@pllim
Copy link
Member Author

pllim commented Aug 28, 2023

Then it probably inherited from parent class docstring? 🤔

@pllim
Copy link
Member Author

pllim commented Aug 28, 2023

Yup... https://github.com/sunpy/ndcube/blob/7f5c8cafbce95c6def7905ef2fb139752cafccc7/ndcube/ndcube.py#L1013

sunpy/ndcube#632

@pllim
Copy link
Member Author

pllim commented Aug 28, 2023

Fixed upstream. Probably need them to release for this to eventually go away.

@pllim pllim closed this as completed Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants