Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Incompatibility with sphinx-dev #173

Closed
bsipocz opened this issue Aug 9, 2023 · 11 comments · Fixed by #174
Closed

BUG: Incompatibility with sphinx-dev #173

bsipocz opened this issue Aug 9, 2023 · 11 comments · Fixed by #174
Labels

Comments

@bsipocz
Copy link
Member

bsipocz commented Aug 9, 2023

At some point this became incompatible with sphinx-dev.

Also, now quite a few versions between 6.1 and sphinx-dev are not included in the text matrix, so it would be nice to add those, too.

@pllim
Copy link
Member

pllim commented Aug 10, 2023

I think @ayshih took care of this in #172

@bsipocz
Copy link
Member Author

bsipocz commented Aug 10, 2023

Do add the new versions to the matrix, too, please.

@ayshih
Copy link
Contributor

ayshih commented Aug 10, 2023

Yeah, the bug is fixed by 62ba0ae

Regarding the test matrix, I'll point out that the builds intended to test against Sphinx 2.4 and 3.5 don't actually manage to install those versions, presumably because setup.cfg specifies Sphinx>=4. Those builds should be removed.

@ayshih
Copy link
Contributor

ayshih commented Aug 10, 2023

Yeah, the bug is fixed by 62ba0ae

Hmm, although one bug was fixed, there's something else that's still a problem (seemingly in pydata-sphinx-theme) with the latest Sphinx.

@ayshih
Copy link
Contributor

ayshih commented Aug 10, 2023

Ah, a PR merged today (sphinx-doc/sphinx#11565) renamed a method called by pydata-sphinx-theme from public to private.

@pllim
Copy link
Member

pllim commented Aug 10, 2023

Oh no... 😱

@pllim
Copy link
Member

pllim commented Aug 10, 2023

I have alerted pydata-sphinx-theme on their Discord but not sure what else we can do here. Either sphinx-dev reverts the breaking change or the theme has to adapt. 😢

@ayshih
Copy link
Contributor

ayshih commented Aug 10, 2023

Heh, I created pydata/pydata-sphinx-theme#1404

@pllim
Copy link
Member

pllim commented Aug 10, 2023

Maybe it is also time to drop Python 3.7?

@bsipocz
Copy link
Member Author

bsipocz commented Aug 10, 2023

Maybe do a release and then drop it? (That's what I'm planning to do elsewhere)

@bsipocz
Copy link
Member Author

bsipocz commented Aug 10, 2023

This compatibility issue is now addressed, and separate issues have been opened about the other things that came up during the discussion. Thanks @ayshih for the fix.

@bsipocz bsipocz closed this as completed Aug 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants