Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change all anchor tags to Javascript redirects #26

Open
gridhead opened this issue Jun 23, 2020 · 4 comments
Open

Change all anchor tags to Javascript redirects #26

gridhead opened this issue Jun 23, 2020 · 4 comments
Assignees
Labels
good first issue Good for newcomers

Comments

@gridhead
Copy link
Member

This prevents the "Open in new tab" thingy - Brings it close to become an app, rather than a website. Feel me?

Replace all the <a href="link"></a> instances with <button onclick="document.location.href='link'"></button>. Well, the button part is optional but just look at the onclick Javascript function. It is the important part.

@VaibhavSaini19
Copy link
Member

Usually, anchor tags open the links in the same page, as the default value for target attribute is target="_self". Maybe try adding this attribute explicitly in the anchor tag, if it is opening the link in new tab currently

@gridhead gridhead added good first issue Good for newcomers hacktoberfest Contribute to the notion of open-source this October! labels Sep 30, 2020
@sourav014
Copy link

I want to solve this issue. Can you assign this to me?

@s-katte
Copy link
Member

s-katte commented Oct 2, 2020

Cool. I will assign you this issue @SOURAVPRASAD49.

Also, feel free to leave a star on the project - should you find it worth your time. Happy hacking! 😄

@gridhead
Copy link
Member Author

gridhead commented Nov 1, 2020

Any updates, @SOURAVPRASAD49?

@gridhead gridhead removed the hacktoberfest Contribute to the notion of open-source this October! label Nov 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants