LIRASignificanceEstimator #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @infinitron, this is very nice functionality! My proposal would be to get this in as fast as possible and later we can improve docs and tests. So the minimal thing to do here for now is run locally: This will highlight all the code style issues, which you can fix locally, push again and then the CI build should turn green... |
adonath
approved these changes
Jun 21, 2022
There was a problem hiding this comment.
Thanks @infinitron! It would be good to add some more documentation, but this can be done any time in future. I opened a reminder issue here #58
Otherwise looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new class called
LIRASignificanceEstimatorto estimate the statistical significance of emission in user-specified regions. This class exposes a method calledestimate_p_valueswhich returns a dictionary with an upper bound on the p-value for each region.plot_xi_distproduces a figure similar to Fig. 3 in Stein et al. 2015.