Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Launch File Updates #13

Merged
merged 5 commits into from Jun 4, 2020
Merged

Launch File Updates #13

merged 5 commits into from Jun 4, 2020

Conversation

icolwell-as
Copy link
Member

Resolves #8

  • Added launch args to make it easier to override certain parameters when including the file.
  • Added the ability to name/namespace multiple cameras using the "name" arg.
  • Added a Mako_G-319.launch file that has some default parameters specific to the Mako G-319.

Need to test with actual camera before merge.

shan-as
shan-as reviewed Jun 3, 2020
View reviewed changes
launch/Mako_G-319.launch Outdated Show resolved Hide resolved
launch/Mako_G-319.launch Show resolved Hide resolved
@icolwell-as
Update stream_bytes_per_second to maximum bandwidth for the Mako G-31…
a3e33a6 
…9, disable output to screen due to excessive logging
@icolwell-as
Copy link
Member Author

Tested with actual camera today.

@icolwell-as icolwell-as merged commit a3567d0 into master Jun 4, 2020
@icolwell-as icolwell-as deleted the 8_launch_file_updates branch June 4, 2020 20:48
@lucleon lucleon mentioned this pull request Feb 16, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shan-as shan-as shan-as approved these changes

@dvangeyn-as dvangeyn-as dvangeyn-as approved these changes

@jilinzhouas jilinzhouas Awaiting requested review from jilinzhouas

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Launch Files
3 participants
@icolwell-as @shan-as @dvangeyn-as