Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Dividing options between NumberPad key layout and newly created configuration file #42

Closed
kamack38 opened this issue Aug 3, 2022 · 3 comments · Fixed by #46
Assignees
Labels
enhancement New feature or request

Comments

@kamack38
Copy link
Member

kamack38 commented Aug 3, 2022

Short Description

Create config file to set layout independent configurations like activation time.

New dependencies

No response

Additional Info

No response

@kamack38 kamack38 added the enhancement New feature or request label Aug 3, 2022
@ldrahnik
Copy link
Member

ldrahnik commented Aug 6, 2022

Variables associated with each NumberPad model (still might be overridden with custom value / create own new one):

  • keys
  • keys_ignore_offset
  • top_left_icon_width
  • top_left_icon_height
  • top_right_icon_width
  • top_right_icon_height
  • top_left_icon_slide_func_keys
  • top_offset
  • right_offset
  • bottom_offset
  • left_offset
  • touchpad_physical_buttons_are_inside_numpad
  • backlight_levels

Config files

  • brightness # [<hex value>] # last brightness
  • auto_disable_due_inactivity_time # [, 0; default 60], 0 means function is disabled = do not auto disable due inactivity
  • multitouch # [1,0; default 0]
  • one_touch_key_rotation # [1,0; default 0]
  • key_repetitions # [1,0; default 0]
  • activation_time_left_icon # [<positive number>, default 1]
  • activation_time # [<positive number>, default 1]
  • touchpad_disables_numpad # [1,0; default 1]
  • top_left_icon_slide_func_activation_x_ratio # [<positive float in range 0-1>, default 0.3]
  • top_left_icon_slide_func_activation_y_ratio # [<positive float in range 0-1>, default 0.3]
  • top_left_icon_brightness_func # [1,0; default 1 but it is <depending value on not empty backlight_levels>] # BUT file should - exists only (should be looked to this variable only) if exist an array of backlight levels, otherwise automatically 0
  • top_left_icon_activate_numpad # [1,0; default 1]
  • enabled # [1,0; default 0] # reflect status enabled/disabled of NumberPad
  • numpad_disables_sys_numlock # [1,0; default 1]
  • top_left_icon_slide_func_activate_numpad # [1,0; default 1]
  • default_backlight_level # [<hex value>, default 0x01]

Static constants

  • try_times # [<positive number>, default 5] # probably will be removed, need to look at why the variable exists
  • try_sleep # [<positive float>, default 0.1] # probably will be removed, need to look at why variable exists

Layout dependent default config values

  • sys_numlock_enables_numpad # [1,0; default 0] # auto enable when does not exist NUMLOCK in keys and right icon has no valid dimension

Delayed because layouts of NumberPad now does not need

Config:

  • top_left_icon_keys # [default [EV_KEY.KEY_CALC]] # TODO add implementation, atm brightness function or nothing, for slide function can be used everything
  • top_right_icon_keys # [default [EV_KEY.KEY_NUMLOCK]] # TODO add implementation, because atm is functionality of right icon every time numlock

@ldrahnik
Copy link
Member

ldrahnik commented Aug 12, 2022

TODO:

  • TODO in code: if is numlock not found in keys array and right icon has no dimensions, in this case auto enable sys_numlock_enables_numpad
  • Readme.md is broken, I separated it to 2 tables
  • config file might not be created because of permission issues (check if it works)

@ldrahnik
Copy link
Member

ldrahnik commented Aug 13, 2022

TODO:
- add enabled config entry and add checking via thread with autoenable; the same for brightness changed via file and maybe more

@ldrahnik ldrahnik changed the title [Feature Request] Configuration file [Feature Request] Dividing options between NumberPad key layout and configuration file Aug 13, 2022
@ldrahnik ldrahnik changed the title [Feature Request] Dividing options between NumberPad key layout and configuration file [Feature Request] Dividing options between NumberPad key layout and newly created configuration file Aug 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants