Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature request] Numpad and Touchpad together #56

Closed
encrustace opened this issue Aug 16, 2022 · 18 comments · Fixed by #81
Closed

[Feature request] Numpad and Touchpad together #56

encrustace opened this issue Aug 16, 2022 · 18 comments · Fixed by #81
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@encrustace
Copy link

Short Description

Can you please implement Touchpad and Numpad works together like windows driver does.
There is already a driver written in Rust and it works in very close to windows.
url in additional info

New dependencies

No response

Additional Info

https://github.com/iamkroot/asus-numpad

@encrustace encrustace added the enhancement New feature or request label Aug 16, 2022
@ldrahnik
Copy link
Member

ldrahnik commented Aug 16, 2022

Hi, thank you for creating an issue.

Can you describe that more please? Do you mean from linked repository Allows using the touchpad when numlock is active? I know that official driver for Windows support scrolling when is NumberPad on but I do not know how is recognized when use NumberPad for scrolling and when not for scrolling but for crossing over keys and key repetitions. It sounds to me like would come a lot of mistakes with this implementation because slide function is recognized with second finger, until we do not know what user want to do.

@ldrahnik ldrahnik changed the title Numpad and Touchpad together [Feature request] Numpad and Touchpad together Aug 16, 2022
@encrustace
Copy link
Author

The repository I have mentioned has implemented the same feature, which means we can use the touchpad when Numpad is active. but it's written in rust, let's try to reverse engineer it

@ldrahnik
Copy link
Member

ldrahnik commented Aug 17, 2022

Can you please more describe that feature. What is expected to do? Use use cases. Like I touch down in this area, is used touchpad. I touch here, is used NumberPad. Thank you.

@ldrahnik ldrahnik added question Further information is requested and removed enhancement New feature or request labels Aug 19, 2022
@ldrahnik
Copy link
Member

ldrahnik commented Aug 19, 2022

Closed because of inactivity of issue owner. Need be specified what does mean "Touchpad and NumberPad work together using use cases" and can be reopen for discussion or implementation.

ldrahnik added a commit that referenced this issue Jan 16, 2023
…en is done any touch and key is not release yet)
@ldrahnik ldrahnik reopened this Jan 16, 2023
@ldrahnik ldrahnik added the enhancement New feature or request label Jan 16, 2023
ldrahnik added a commit that referenced this issue Jan 16, 2023
…en is done any touch and key is not release yet)
ldrahnik added a commit that referenced this issue Jan 16, 2023
…en is done any touch and key is not release yet)
@ldrahnik ldrahnik removed the question Further information is requested label Jan 16, 2023
@ldrahnik
Copy link
Member

@encrustace ping

@ldrahnik ldrahnik added the help wanted Extra attention is needed label Jan 17, 2023
@encrustace
Copy link
Author

Today I'll try and will update here the result

@encrustace
Copy link
Author

For starting 10 seconds it works after that touchpad light is glowing but neither the trackpad nor Numpad is working and after rebooting again same.

ldrahnik added a commit that referenced this issue Jan 19, 2023
…en is done any touch and key is not release yet)
ldrahnik added a commit that referenced this issue Jan 19, 2023
…ed when is done any touch and key is not release yet)
@ldrahnik
Copy link
Member

@encrustace Should be fixed now.

@ldrahnik
Copy link
Member

@encrustace Let me please know that update fixed this issue.

@encrustace
Copy link
Author

Ok, I'll test it today and will update

@ldrahnik
Copy link
Member

ldrahnik commented Jan 21, 2023

@encrustace Ok, I look forward to your feedback.

@encrustace
Copy link
Author

@ldrahnik Numpad and Trackpad work together fine but in some applications such as notepad where the edit area is always in focus, it types one number from where you start to move the cursor, like if the position is at 5 then it will type 5 and then the cursor will start moving.

@ldrahnik
Copy link
Member

ldrahnik commented Jan 21, 2023

@encrustace On Windows is using of this feature a bit controversial too or it is working perfectly as user would expect? Do you know? Did you try? I mean a decision about what to do, touch the number or only do a cursor move. Not too long waiting for number but perfectly long to avoid touching number if move was started.

@encrustace
Copy link
Author

encrustace commented Jan 21, 2023

@ldrahnik I have never used windows, used windows to just download Linux on this machine so not sure if it was working or not. but one thing you can try is that if the time difference between touch and untouch is very quick (in a certain range) then consider it as touch else its s a cursor move. or another approach could be like if the touch point and untouch point x y axis have a particular distance then it will move else it will be touch. as you mentioned you are using time delay to differentiate so try the second approach if that does also not work then at least an option can be added in configuration to delay touch.

@ldrahnik ldrahnik linked a pull request Jan 21, 2023 that will close this issue
@ldrahnik
Copy link
Member

ldrahnik commented Jan 21, 2023

@encrustace In mentioned branch 56-numpad-touchpad-together I implemented idea add the option to write the NumberPad key when is touch released / touch is untouched (newly added option press_key_when_is_done_untouch = 1, by default enabled) and with disabled option one_touch_key_rotation = 0 (by default disabled) is done only pointer move when is at least one time crossed border of the key where was touch initialized. Please test it and let me know your feedback. In my opinion is this only possible clean way how to implement this feature.

@encrustace
Copy link
Author

@ldrahnik This is working amazing, exactly as a user would wanted.

One thing can be improved, I know this is very tough to implement but can be given a thought, like I am typing something is a notepad and I want to correct some word and trying to move edit pointer at a specific line, now it bring pointer to that line but it also typed a number or operation symbol, In simple word what if it could differentiate between type click and focus click. it can be done by comparing the current position of cursor and edit pointer position, but challenge will be checking current what application is in focus is it an editor or edit box or edit field.

@encrustace
Copy link
Author

I am not asking, I am just giving feedback, you have done an amazing work already.

@ldrahnik
Copy link
Member

ldrahnik commented Jan 22, 2023

@encrustace I am afraid, that is not possible to implement. My recommendation is to use the pointer left button when is click done somewhere where is also possible to write number/char as I do. Of course in these moments have an advantages laptops with pointer buttons outside of touchpad area :)

ldrahnik added a commit that referenced this issue Jan 22, 2023
…ed NumberPad via writting number/char when is key untouched
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants