Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing LED mappings for Maschine MK3 #10

Open
dkzeb opened this issue Jun 4, 2024 · 2 comments
Open

Missing LED mappings for Maschine MK3 #10

dkzeb opened this issue Jun 4, 2024 · 2 comments

Comments

@dkzeb
Copy link

dkzeb commented Jun 4, 2024

Hi! 馃憢

Firstly, thanks for your work on this project! 馃檪

Today I used patch-package to patch ni-controllers-lib@1.2.3 for the project I'm working on. The Maschine MK3 configuration was missing mappings for the "mixer", "browserPlugin" and "sampling" LEDs

diff --git a/node_modules/ni-controllers-lib/dist/lib/maschine_mk3_config.json b/node_modules/ni-controllers-lib/dist/lib/maschine_mk3_config.json
index 0c021ef..a07ea15 100644
--- a/node_modules/ni-controllers-lib/dist/lib/maschine_mk3_config.json
+++ b/node_modules/ni-controllers-lib/dist/lib/maschine_mk3_config.json
@@ -759,9 +759,15 @@
             "arranger": {
                 "addr": 3
             },            
-            "browserPlugin": {
+            "mixer": {
                 "addr": 4
             },
+            "browserPlugin": {
+                "addr": 5
+            },
+            "sampling": {
+                "addr": 6
+            },
             "arrowLeft": {
                 "addr": 7
             },

This issue body was partially generated by patch-package.

@asutherland
Copy link
Owner

Thanks for filing the issue! It seems we do have a (mis-named) sampler entry in the indexed_leds section so this probably needs a little more investigation to figure out if any of these are multi-color or not, but it's definitely clear there's a gap/errors here.

I should be able to get to this in the next few weeks, but would be happy to accept a pull request.

@dkzeb
Copy link
Author

dkzeb commented Jun 4, 2024

Sure :) i actually found this lib while i was preparing to build my own, so you saved me a ton of work ;) - i'll take a look at submitting a PR ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants