Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate keyboard-quickfix with vscode-neovim #469

Closed
David-Else opened this issue Dec 29, 2020 · 7 comments
Closed

Integrate keyboard-quickfix with vscode-neovim #469

David-Else opened this issue Dec 29, 2020 · 7 comments
Labels
enhancement New feature or request

Comments

@David-Else
Copy link
Contributor

It seems the quick-fix menu uses the standard context menu that has no ability to use anything other than the arrow keys to navigate up and down:

microsoft/vscode#88076

I think it is the same thing with the ctrl-shift-r refactor menu too? Anyone have any luck getting j/k or alt-j / alt-k working in these?

@asvetliakov
Copy link
Member

asvetliakov commented Dec 29, 2020

As far as i know - no. There was another feature request in vscode repo, but i can't seem to find it.
It's real pain on Win, since even <C-n>/<C-p> don't work here.

@David-Else
Copy link
Contributor Author

David-Else commented Dec 31, 2020

@asvetliakov There is a solution in the https://github.com/PascalSenn/keyboard-quickfix extension:

    // open quickfix
    {
        "key": "ctrl+.",
        "command": "keyboard-quickfix.openQuickFix",
        "when": "editorHasCodeActionsProvider && editorTextFocus && !editorReadonly"
    },
    {
        "key": "j",
        "command": "list.focusDown",
        "when": "listFocus && !inputFocus"
    },
    {
        "key": "k",
        "command": "list.focusUp",
        "when": "listFocus && !inputFocus"
    }

https://github.com/PascalSenn/keyboard-quickfix/blob/master/src/extension.ts

Thanks to @theol0403 for this info #457 (comment)

Could you use a modified version of this code to add the capability to vscode-neovim?

@asvetliakov
Copy link
Member

Why duplicate functionality when you can just install that extension?

@David-Else
Copy link
Contributor Author

@asvetliakov You have a very valid point, but here are a few counter-arguments to consider:

  • Integrating the code removes another extension dependency that could become unmaintained or break functionality with other extensions. Every extension installed is a liability to long-term productivity.
  • It adds a very important feature that the user will want out of the box, they don't want to install another extension for basic functionality
  • The code could be streamlined and the generic extension boilerplate removed eradicating bloat from the universe
  • The extra functionality of keyboard-quickfix is ONLY needed for VS Code Vim extensions, so why not have it built right in? You could also add the shortcuts as default, standardizing the use

I don't think VS Code is getting this functionality any time soon based on microsoft/vscode#55111 and similar requests I have read.

I don't know what the best thing to do is really, @theol0403 what do you think?

@asvetliakov asvetliakov added enhancement New feature or request question labels Jan 3, 2021
@alanmrochadeveloper
Copy link

alanmrochadeveloper commented Mar 29, 2021

A workaround for whose can't find a solution > microsoft/vscode#55111 (comment)
Remember to set it as you like, as it fits you, for me alt+f/e/s/d for arrow keys, but vim user can simulate vim shortcuts.

@theol0403
Copy link
Member

theol0403 commented Apr 2, 2021

I don't know what the best thing to do is really, @theol0403 what do you think?

Sorry for the very late reply. I do agree with all your points. I don't have the typescript knowledge to merge the plugins together, but I think if vscode-neovim provides this functionality it would be nice. That way, z= and ctrl-. can be configured to open the keyboard quicklist by default.

@theol0403 theol0403 changed the title Is there any way to assign j/k shortcuts to the quickfix and refactor menu? Integrate keyboard-quickfix with vscode-neovim Apr 29, 2022
@jgirardet
Copy link

microsoft/vscode#55111 (comment)
should be marked as resolved ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants